Skip to content

fix(file-api): fix schema field for file name #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldogonzalez8 merged 2 commits into from
Apr 22, 2025
Merged

fix(file-api): fix schema field for file name #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5de055d
file-api: fix schema field for file name
aldogonzalez8 Apr 22, 2025
f68547b
file-api: fix typo
aldogonzalez8 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/file_based/file_record_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class FileRecordData(BaseModel):
"""

folder: str
filename: str
file_name: str
bytes: int
source_uri: str
id: Optional[str] = None
Expand Down
4 changes: 2 additions & 2 deletions unit_tests/sources/file_based/stream/test_default_file_based_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ class DefaultFileBasedStreamFileTransferTest(unittest.TestCase):
_NOW = datetime(2022, 10, 22, tzinfo=timezone.utc)
_A_FILE_RECORD_DATA = FileRecordData(
folder="/absolute/path/",
filename="file.csv",
file_name="file.csv",
bytes=10,
source_uri="file:///absolute/path/file.csv",
)
Expand Down Expand Up @@ -337,7 +337,7 @@ def test_when_read_records_from_slice_then_return_records(self) -> None:
assert list(map(lambda message: message.record.data, messages)) == [
{
"bytes": 10,
"filename": "file.csv",
"file_name": "file.csv",
"folder": "/absolute/path/",
"source_uri": "file:///absolute/path/file.csv",
}
Expand Down
Loading