Skip to content

fix(cdk): Remove fallback mechanism and properly configure user namespaces#401

Closed
devin-ai-integration[bot] wants to merge 5 commits intodevin/1741546903-fix-gvisor-permissionsfrom
devin/1741554867-fix-rootless-container
Closed

fix(cdk): Remove fallback mechanism and properly configure user namespaces#401
devin-ai-integration[bot] wants to merge 5 commits intodevin/1741546903-fix-gvisor-permissionsfrom
devin/1741554867-fix-rootless-container

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 9, 2025

This PR targets the following PR:


Remove fallback mechanism and properly configure user namespaces

This PR addresses the error "running container: creating container: cannot create gofer process: unable to run a rootless container without userns" in the gVisor sandboxing implementation by removing the fallback mechanism and properly configuring user namespaces.

Changes

  • Removed fallback mechanism from gVisor wrapper script
  • Updated OCI configuration with proper user namespace settings
  • Modified Dockerfile to configure kernel parameters for unprivileged user namespace cloning
  • Updated devlog entry documenting the changes and requirements for production use

Testing

The implementation was tested with various configurations:

  • Basic run: docker run --rm airbyte/source-declarative-manifest-gvisor spec
  • Privileged mode: docker run --rm --privileged airbyte/source-declarative-manifest-gvisor spec
  • User namespace support: docker run --rm --userns=host airbyte/source-declarative-manifest-gvisor spec

Link to Devin run: https://app.devin.ai/sessions/b83c0c0d80bc471fa2f67ae714022968

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - Please create a PR against the PR here: <https://github.com/airbytehq/airbyte-python-cdk/pull/400>

With the goal of resolving this error `running container: creating container: cannot create gofer process: unable to run a rootless container without userns`

Maintain a devlog according to the instructions in the repo.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the bug Something isn't working label Mar 9, 2025
@aaronsteers Aaron ("AJ") Steers (aaronsteers) changed the base branch from main to devin/1741546903-fix-gvisor-permissions March 9, 2025 21:20
devin-ai-integration bot and others added 2 commits March 9, 2025 21:24
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
…paces

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration devin-ai-integration bot changed the title fix(cdk): Resolve rootless container user namespace issue (do not merge) fix(cdk): Remove fallback mechanism and properly configure user namespaces Mar 9, 2025
devin-ai-integration bot and others added 2 commits March 9, 2025 22:18
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant