fix(low-code cdk): fix partition router validation for async retriever

[Serhii Lazebnyi (lazebnyi)]

This PR fixes an issue with partition_router validation for AsyncRetriever and allows creating a slicer when stream_slicer_from_partition_router is built.

link to thread - https://airbytehq-team.slack.com/archives/C02U9R3AF37/p1741883530973919

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the control flow in the _merge_stream_slicers method within the ModelToComponentFactory class. A new initialization of the stream_slicer variable is added via a call to _build_stream_slicer_from_partition_router with retriever_model and config as arguments. The conditional logic now checks whether stream_slicer is unset along with retriever_model.type conditions, and it raises a ValueError if both conditions are met. Additionally, a redundant assignment of stream_slicer has been removed, streamlining the method’s overall flow.

Changes

File	Change Summary
airbyte_cdk/.../model_to_component_factory.py	- Added initialization of stream_slicer using _build_stream_slicer_from_partition_router(retriever_model, config). - Modified condition to check for unset stream_slicer along with retriever_model.type and raise a ValueError if conditions are met. - Removed redundant assignment of stream_slicer at the end of the method.

Sequence Diagram(s)

sequenceDiagram
    participant F as ModelToComponentFactory
    participant B as _build_stream_slicer_from_partition_router
    participant E as Error Handler

    F->>B: Call(_build_stream_slicer_from_partition_router(retriever_model, config))
    B-->>F: Return stream_slicer
    alt Partition router active & stream_slicer is not set
        F->>E: Raise ValueError("Per partition state is not supported yet for AsyncRetriever")
    else Stream slicer is valid or not a partition router
        F->>F: Continue normal processing
    end

Loading

Would you like any additional details or further diagrams to better illustrate the modified control flow, wdyt?

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ad9e09 and f14aed6.

📒 Files selected for processing (1)

• airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Check: 'source-pokeapi' (skip=false)
• GitHub Check: Check: 'source-amplitude' (skip=false)
• GitHub Check: Check: 'source-shopify' (skip=false)
• GitHub Check: Check: 'source-hardcoded-records' (skip=false)
• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (Fast)
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)
• GitHub Check: SDM Docker Image Build
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py (2)

1903-1904: Good improvement to ensure consistent validation logic!

This change properly initializes the stream_slicer variable earlier by calling _build_stream_slicer_from_partition_router. This helps with the subsequent validation checks and makes the overall flow clearer.

---

1924-1928: Enhanced validation to prevent potential issues, nice!

Adding the not stream_slicer condition to the check is a good improvement. Now the error will only be raised when there's a partition router defined but the stream slicer couldn't be built, which is a more precise check for this error scenario.

The error message clearly communicates that per-partition state isn't supported for AsyncRetriever, which helps developers understand the limitation.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.