Skip to content

feat: skip config validation during discovery for sources with DynamicSchemaLoader#466

Closed
devin-ai-integration[bot] wants to merge 21 commits intomainfrom
devin/1744215320-dynamic-schema-unprivileged-discovery-aj
Closed

feat: skip config validation during discovery for sources with DynamicSchemaLoader#466
devin-ai-integration[bot] wants to merge 21 commits intomainfrom
devin/1744215320-dynamic-schema-unprivileged-discovery-aj

Conversation

@devin-ai-integration
Copy link
Contributor

Allow Airbyte sources to run discovery unprivileged with DynamicSchemaLoader

This PR allows Airbyte sources to run discovery unprivileged if the source API doesn't need auth in order to provide the catalog info.

Implementation

  1. Added automatic detection of DynamicSchemaLoader to skip config validation during discovery. When a source uses the dynamic schema feature, we assume that the schema endpoint might not require authentication and automatically skip config validation during discovery.

  2. Modified the AirbyteEntrypoint to make the --config parameter optional for the discover command. This allows running discovery without providing a config file when the source doesn't require config validation.

This enables sources with dynamic schemas to provide catalog information without authentication when the schema endpoint doesn't require it.

Testing

Added unit tests to verify that:

  • Sources using DynamicSchemaLoader skip config validation during discovery
  • Sources not using DynamicSchemaLoader still require config validation
  • The AirbyteEntrypoint correctly handles discovery without config when appropriate

Link to Devin run: https://app.devin.ai/sessions/e6aa19df336347919b6cabcff7143a1c
Requested by: Aaron ("AJ") Steers (aj@airbyte.io)

devin-ai-integration bot and others added 21 commits April 8, 2025 22:33
…cSchemaLoader

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
…ation control

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
…class

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
…ver property

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Contributor Author

Original prompt from Aaron:

@Devin - We want to allow Airbyte sources to run discovery unprivileged if the source API doesn't need auth in order to provide the catalog info. Please try to update the declarative manifest implementation in the CDK to succeed in running `discover` even if no auth ("config") is provided by the user. Make sure you test up front that running discovery does indeed fail. Then try to update the connector to skip the check for config. We can use a flag in the source class (or another suitable location) to tell the implementation explicitly to require config or not during discovery.

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments