experiment: cdk oauth refactor with Cursor#474
Draft
David Gold (dbgold17) wants to merge 2 commits intomainfrom
Draft
experiment: cdk oauth refactor with Cursor#474David Gold (dbgold17) wants to merge 2 commits intomainfrom
David Gold (dbgold17) wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP] - putting up for a quick sanity check on direction / value of this change before I spend any more time on it.
This is an experiment to use Cursor to refactor the CDK OAuth module. On top of hopefully providing value in terms of code and test quality, this is a good learning experience for me working with Cursor.
Upon diving into cdk OAuth work I noticed lots of complexity with the implementation that made it difficult to make even a small change. Have to update the same thing in multiple places, hard to conceptually understand the branching logic flows, hard to get confidence that changes will not break something (even assuming unit tests are passing).
I think this warrants improvement for the following reasons:
new implementation:
old implementation: