fix: only check for file upload if stream is declarative

[maxi297]

Given sources that are in transition from being declarative, we will have streams that are not in the manifest and therefore we will have a KeyError: '<stream name>' when grouping the streams

Summary by CodeRabbit

• Bug Fixes
  • Improved type checking to prevent errors when determining file transfer support for streams.

[maxi297]

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change introduces an additional type check within the _group_streams method of the ConcurrentDeclarativeSource class. Specifically, before checking if the "file_uploader" key exists in a stream's configuration, the code now verifies that the stream is an instance of DeclarativeStream. This adjustment ensures that the key check is only performed on appropriate stream types, enhancing type safety and preventing potential runtime errors.

Changes

File(s)	Change Summary
airbyte_cdk/sources/declarative/concurrent_declarative_source.py	Added an isinstance check for DeclarativeStream before checking for "file_uploader" in the stream configuration within the _group_streams method.

Possibly related PRs

• chore: fix typing issues #135: Both PRs modify the _group_streams method in ConcurrentDeclarativeSource within concurrent_declarative_source.py, focusing on refining stream type checks and configuration handling.
• fix: When grouping streams, ensure stream is declarative before checking in the manifest #425: Both PRs modify the _group_streams method in concurrent_declarative_source.py to add isinstance checks ensuring streams are DeclarativeStream before accessing their manifest data, directly addressing type safety in stream grouping.

Suggested labels

bug

Suggested reviewers

• maxi297
• pnilan
• lazebnyi

Would you like to consider if any additional unit tests should be added to cover this new type-checking logic, wdyt?

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd7c64a and 051dba8.

📒 Files selected for processing (1)

• airbyte_cdk/sources/declarative/concurrent_declarative_source.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• airbyte_cdk/sources/declarative/concurrent_declarative_source.py

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Check: 'source-pokeapi' (skip=false)
• GitHub Check: Check: 'source-amplitude' (skip=false)
• GitHub Check: Check: 'source-shopify' (skip=false)
• GitHub Check: Check: 'source-hardcoded-records' (skip=false)
• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)
• GitHub Check: SDM Docker Image Build
• GitHub Check: Pytest (Fast)
• GitHub Check: Analyze (python)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0fcbc and bd7c64a.

📒 Files selected for processing (1)

• airbyte_cdk/sources/declarative/concurrent_declarative_source.py (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

airbyte_cdk/sources/declarative/concurrent_declarative_source.py (2)

airbyte_cdk/sources/declarative/models/declarative_component_schema.py (1)

• DeclarativeStream (2094-2157)

airbyte_cdk/sources/declarative/declarative_stream.py (1)

• DeclarativeStream (32-241)

🪛 GitHub Actions: Linters

airbyte_cdk/sources/declarative/concurrent_declarative_source.py

[error] 1-1: Ruff formatting check failed. File would be reformatted. Run 'ruff format' to fix code style issues.

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Check: 'source-pokeapi' (skip=false)
• GitHub Check: Check: 'source-amplitude' (skip=false)
• GitHub Check: Check: 'source-shopify' (skip=false)
• GitHub Check: Check: 'source-hardcoded-records' (skip=false)
• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)
• GitHub Check: SDM Docker Image Build
• GitHub Check: Pytest (Fast)
• GitHub Check: Analyze (python)

[aldogonzalez8]

APPROVED