Skip to content

feat(low-code): pass top level params to PropertiesFromEndpoint requester #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daryna Ishchenko (darynaishchenko) merged 7 commits into from
May 15, 2025
Merged

feat(low-code): pass top level params to PropertiesFromEndpoint requester #543

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed0e804
pass top level params to PropertiesFromEndpoint requester
darynaishchenko May 13, 2025
a474f5e
Auto-fix lint and format issues
May 13, 2025
708ceeb
mypy fix
darynaishchenko May 13, 2025
f4ca661
pass parameters in ManifestComponentTransformer
darynaishchenko May 14, 2025
69eb0cf
refactor code
darynaishchenko May 14, 2025
d9f0d6f
updated doc comment
darynaishchenko May 14, 2025
1736750
refactor code
darynaishchenko May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2758,6 +2758,9 @@ def create_parent_stream_config(
def create_properties_from_endpoint(
self, model: PropertiesFromEndpointModel, config: Config, **kwargs: Any
) -> PropertiesFromEndpoint:
parameters = model.retriever.requester.parameters or {}
parameters.update(model.parameters or {})
model.retriever.requester.parameters = parameters
retriever = self._create_component_from_model(
model=model.retriever,
config=config,
Expand Down Expand Up @@ -2808,8 +2811,12 @@ def create_query_properties(
if isinstance(model.property_list, list):
property_list = model.property_list
else:
property_list_model = model.property_list
parameters = property_list_model.parameters if property_list_model.parameters is not None else {}
parameters.update(model.parameters or {})
property_list_model.parameters = parameters
property_list = self._create_component_from_model(
model=model.property_list, config=config, **kwargs
model=property_list_model, config=config, **kwargs
)

property_chunking = (
Expand Down Expand Up @@ -3046,8 +3053,12 @@ def _get_url() -> str:
)

if len(query_properties_definitions) == 1:
query_properties_definition_model = query_properties_definitions[0]
parameters = query_properties_definition_model.parameters if query_properties_definition_model.parameters is not None else {}
parameters.update(model.parameters or {})
query_properties_definition_model.parameters = parameters
query_properties = self._create_component_from_model(
model=query_properties_definitions[0], config=config
model=query_properties_definition_model, config=config
)
elif (
hasattr(model.requester, "fetch_properties_from_endpoint")
Expand Down
Loading