Skip to content

fix(tests): resolve issue with 'exception' status raising failure of FAST container tests #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronsteers merged 3 commits into from
Jun 23, 2025
Merged

fix(tests): resolve issue with 'exception' status raising failure of FAST container tests #606

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49f677d
fix(tests): resolve issue with 'exception' status raising failure of …
aaronsteers Jun 23, 2025
04a7c65
add source-google-adds as test connector
aaronsteers Jun 23, 2025
9ac9514
revert added connector test
aaronsteers Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/connector-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ jobs:
cdk_extra: n/a
- connector: source-google-drive
cdk_extra: file-based
- connector: source-google-ads
cdk_extra: n/a
- connector: destination-motherduck
cdk_extra: sql
- connector: source-amplitude
Expand Down
5 changes: 4 additions & 1 deletion airbyte_cdk/test/models/outcome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ def from_status_str(cls, status: str | None) -> ExpectedOutcome:
return {
"succeed": ExpectedOutcome.EXPECT_SUCCESS,
"failed": ExpectedOutcome.EXPECT_EXCEPTION,
"exception": ExpectedOutcome.EXPECT_EXCEPTION, # same as 'failed'
}[status]
except KeyError as ex:
raise ValueError(f"Invalid status '{status}'. Expected 'succeed' or 'failed'.") from ex
raise ValueError(
f"Invalid status '{status}'. Expected 'succeed', 'failed', or 'exception'.",
) from ex

@classmethod
def from_expecting_exception_bool(cls, expecting_exception: bool | None) -> ExpectedOutcome:
Expand Down
Loading