Skip to content

fix: parameters propagation issues for concurrent cursors #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxi297 merged 5 commits into from
Aug 26, 2025
Merged

fix: parameters propagation issues for concurrent cursors #726

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d6bbed
fix parameters propagation issues for concurrent cursors
Aug 26, 2025
1cd879f
add unit test
Aug 26, 2025
d739e47
fix mypy
Aug 26, 2025
c0e8b86
format
Aug 26, 2025
183262c
retrigger CI
Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,12 @@ def create_concurrent_cursor_from_datetime_based_cursor(
f"Expected manifest component of type {model_type.__name__}, but received {component_type} instead"
)

# FIXME the interfaces of the concurrent cursor are kind of annoying as they take a `ComponentDefinition` instead of the actual model. This was done because the ConcurrentDeclarativeSource didn't have access to the models [here for example](https://github.com/airbytehq/airbyte-python-cdk/blob/f525803b3fec9329e4cc8478996a92bf884bfde9/airbyte_cdk/sources/declarative/concurrent_declarative_source.py#L354C54-L354C91). So now we have two cases:
# * The ComponentDefinition comes from model.__dict__ in which case we have `parameters`
# * The ComponentDefinition comes from the manifest as a dict in which case we have `$parameters`
# We should change those interfaces to use the model once we clean up the code in CDS at which point the parameter propagation should happen as part of the ModelToComponentFactory.
if "$parameters" not in component_definition and "parameters" in component_definition:
component_definition["$parameters"] = component_definition.get("parameters")
datetime_based_cursor_model = model_type.parse_obj(component_definition)

if not isinstance(datetime_based_cursor_model, DatetimeBasedCursorModel):
Expand Down Expand Up @@ -1582,6 +1588,12 @@ def create_concurrent_cursor_from_perpartition_cursor(
f"Expected manifest component of type {model_type.__name__}, but received {component_type} instead"
)

# FIXME the interfaces of the concurrent cursor are kind of annoying as they take a `ComponentDefinition` instead of the actual model. This was done because the ConcurrentDeclarativeSource didn't have access to the models [here for example](https://github.com/airbytehq/airbyte-python-cdk/blob/f525803b3fec9329e4cc8478996a92bf884bfde9/airbyte_cdk/sources/declarative/concurrent_declarative_source.py#L354C54-L354C91). So now we have two cases:
# * The ComponentDefinition comes from model.__dict__ in which case we have `parameters`
# * The ComponentDefinition comes from the manifest as a dict in which case we have `$parameters`
# We should change those interfaces to use the model once we clean up the code in CDS at which point the parameter propagation should happen as part of the ModelToComponentFactory.
if "$parameters" not in component_definition and "parameters" in component_definition:
component_definition["$parameters"] = component_definition.get("parameters")
datetime_based_cursor_model = model_type.parse_obj(component_definition)

if not isinstance(datetime_based_cursor_model, DatetimeBasedCursorModel):
Expand Down
Loading