-
Notifications
You must be signed in to change notification settings - Fork 32
chore: clean up ConcurrentDeclarativeSource only processing DefaultStream and streamline inheritance to Source interface #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4cb9150
clean up ConcurrentDeclarativeSource only processing DefaultStream, s…
brianjlai c8f2c12
Merge branch 'main' into brian/streamline_cds_move_legacy_components
brianjlai 5ca41a9
remove unneeded tests
brianjlai bbaf25a
pr feedback
brianjlai c63ca4a
cleaning out annoying usages importing dependencies from airbyte_cdk …
brianjlai e5bc81c
remove usage of legacy components from test
brianjlai 723f940
remove extra dependencies and make AbstractStream no longer experimental
brianjlai 072b739
Merge branch 'main' into brian/streamline_cds_move_legacy_components
brianjlai e6f9485
pr feedback
brianjlai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
airbyte_cdk/legacy/sources/declarative/incremental/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,31 @@ | ||
| # Copyright (c) 2025 Airbyte, Inc., all rights reserved. | ||
|
|
||
| from airbyte_cdk.legacy.sources.declarative.incremental.datetime_based_cursor import ( | ||
| DatetimeBasedCursor, | ||
| ) | ||
| from airbyte_cdk.legacy.sources.declarative.incremental.declarative_cursor import DeclarativeCursor | ||
| from airbyte_cdk.legacy.sources.declarative.incremental.global_substream_cursor import ( | ||
| GlobalSubstreamCursor, | ||
| ) | ||
| from airbyte_cdk.legacy.sources.declarative.incremental.per_partition_cursor import ( | ||
| CursorFactory, | ||
| PerPartitionCursor, | ||
| ) | ||
| from airbyte_cdk.legacy.sources.declarative.incremental.per_partition_with_global import ( | ||
| PerPartitionWithGlobalCursor, | ||
| ) | ||
| from airbyte_cdk.legacy.sources.declarative.incremental.resumable_full_refresh_cursor import ( | ||
| ChildPartitionResumableFullRefreshCursor, | ||
| ResumableFullRefreshCursor, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "CursorFactory", | ||
| "DatetimeBasedCursor", | ||
| "DeclarativeCursor", | ||
| "GlobalSubstreamCursor", | ||
| "PerPartitionCursor", | ||
| "PerPartitionWithGlobalCursor", | ||
| "ResumableFullRefreshCursor", | ||
| "ChildPartitionResumableFullRefreshCursor", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.