-
Notifications
You must be signed in to change notification settings - Fork 32
chore: Remove unused psutil dependency #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: AJ Steers <[email protected]>
Original prompt from AJ Steers |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1762965638-remove-psutil#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1762965638-remove-psutilHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the psutil dependency from the Python CDK as it was identified as unused and already marked for potential removal. The change cleans up the dependency list by removing both the dependency declaration and its corresponding ignore list entry.
Key changes:
- Removed psutil version 6.1.0 from project dependencies
- Cleaned up the deptry ignore list by removing the psutil entry
- Confirmed psutil is not a transitive dependency in the updated lock file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughThe pull request removes the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PyTest Results (Fast)3 811 tests ±0 3 799 ✅ - 1 6m 31s ⏱️ -41s Results for commit 99e5478. ± Comparison against base commit f0443aa. This pull request skips 1 test. |
chore: Remove unused psutil dependency
Summary
Removed the psutil dependency (version 6.1.0) from the Python CDK as it was marked as unused and listed in the deptry ignore list for unused dependencies. After removal, confirmed that psutil does not remain in the lock file as a transitive dependency of any other package.
Changes:
psutil = "6.1.0"from[tool.poetry.dependencies]in pyproject.toml"psutil"from the deptry DEP002 ignore listReview & Testing Checklist for Human
This is a yellow risk change (dependency removal). Please verify:
git grep -i psutilacross the repository to ensure no code is importing or using psutilpytest-fastwhich passed (3809 tests), but the full test suite should be run to catch any edge casesTest Plan
poetry run poe pytestgit grep -i psutil(should return no results in source code)Notes
# TODO: Remove if unusedin pyproject.tomlRequested by: AJ Steers (@aaronsteers)
Devin session: https://app.devin.ai/sessions/44e0277811b64f30b178f8edac6fb7d0
Summary by CodeRabbit