Source Sendgrid: Update manifest for adapting changes with AsyncRetriever#55185
Source Sendgrid: Update manifest for adapting changes with AsyncRetriever#55185btkcodedev (btkcodedev) merged 12 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/bump-version type="minor" changelog="Update manifest for adapting changes with AsyncRetriever"
|
|
This is ready |
Hey btkcodedev (@btkcodedev) we've prepared another small update for CDK > Decoders to be able to re-use them instead of the So, after this one is merged and released, we would need to update this PR as follows:
download_extractor:
type: ResponseToFileExtractorWith the following: download_decoder:
type: GzipDecoder
decoder:
type: CsvDecoderOnce the tests are green we should be good to merge it. |
|
Ok Thanks, Will do after airbytehq/airbyte-python-cdk#378 is merged!! 🙇 |
|
btkcodedev (@btkcodedev) The CDK update mentioned earlier was merged, please refer to |
Baz (bazarnov)
left a comment
There was a problem hiding this comment.
Minor Change:
- Replace
pathwithurl_basein thedownload_requester.
After this modification, the code will be LGTM.
Thank you, btkcodedev (@btkcodedev)
|
Baz (@bazarnov), the bounces stream was fine before the upgrade, its failing now, any idea why? |
|
the stream looks untouched for me though! |
|
The Looks like we should update them Danylo Jablonski (@DanyloGL) Could you please help with this? Alternatively, we can skip checking this stream in the |
|
btkcodedev (@btkcodedev) I confirm that with the old CDK |
|
Added! This should work now |
|
Feel free to merge, once the CI is green again. |
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11787
How
Definition of Done:
The source-sendgrid works with the updated manifest.yaml considering the changes made here
In specific:
upgrade the CDK version to at least 6.36.3
rename the urls_extractor to download_target_extractor, here
move off the stream_slice interpolation context to use the {{creation_response['id']}}, here
move off the stream_slice interpolation context to use the {{download_target}}, here
make sure the CAT passes, as before
make sure the Regression Tests pass, as before
no source behaviour changes are expected
Follow the airbytehq/airbyte-python-cdk#368 (User Impact section) for more information about the changes.