🐛 Source Salesforce: Fix state parsing issue#55898
Merged
Maxime Carbonneau-Leclerc (maxi297) merged 4 commits intomasterfrom Mar 25, 2025
Merged
🐛 Source Salesforce: Fix state parsing issue#55898Maxime Carbonneau-Leclerc (maxi297) merged 4 commits intomasterfrom
Maxime Carbonneau-Leclerc (maxi297) merged 4 commits intomasterfrom
Conversation
Maxime Carbonneau-Leclerc (maxi297)
requested a review
from a team
as a code owner
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Maxime Carbonneau-Leclerc (maxi297)
requested review from
Aldo Gonzalez (aldogonzalez8) and
Baz (bazarnov)
Baz (bazarnov)
approved these changes
Mar 21, 2025
Contributor
Author
|
Running regression tests here: https://github.com/airbytehq/airbyte/actions/runs/14036199134 EDIT: killed because it was too long. I used a connection which I know the sync shouldn't be so long: https://github.com/airbytehq/airbyte/actions/runs/14040416187 |
Contributor
Author
|
/approve-regression-tests The catalog is different but it is dynamic so I'm not too worried about that
|
Maxime Carbonneau-Leclerc (maxi297)
merged commit 432f6d2
into
master
28 of 29 checks passed
Maxime Carbonneau-Leclerc (maxi297)
deleted the
maxi297/fix-salesforce-cursor-parsing-issue
branch
Sven Pöche (Valgard)
pushed a commit
to mayflower/airbyte
that referenced
this pull request
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Following rollback here, this is the fix to ensure we don't fail on serializing the state.
How
Up the CDK version following airbytehq/airbyte-python-cdk#436
Review guide
Test has been updated before the CDK upgrade to reproduce
'str' object has no attribute 'year'error and the test was updated to reflect the new state.User Impact
We can update the CDK to the newest version and it should pick up auto update now.
For the end user, nothing should change.
Can this PR be safely reverted and rolled back?
This will start populating
most_recent_cursor_valuein the DB which will start creating this error in the DB if we revert to 2.6.5