Skip to content

Conversation

@tolik0
Copy link
Contributor

@tolik0 tolik0 commented Nov 21, 2025

What

  • Replaced .* with [\s\S]*? so matches work across multiple lines.
  • Removed the LIMIT requirement (unnecessary).
  • Fixed logic to handle regex_search returning an empty string ("") when no match is found, instead of None as previously assumed.

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@github-actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /run-live-tests - Runs live tests for the modified connector(s).
  • /run-regression-tests - Runs regression tests for the modified connector(s).
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version bump=patch changelog='foo' - Bump the Bulk CDK's version. bump can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@tolik0 tolik0 self-assigned this Nov 21, 2025
@tolik0 tolik0 marked this pull request as ready for review November 21, 2025 15:13
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Starting regression tests (filter: --modified)
Workflow run: 19574884825
Regression tests: ✅ PASSED
Report: not generated
LLM Evaluation: ⚠️ Did not run

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

source-google-ads Connector Test Results

93 tests   89 ✅  5m 1s ⏱️
 2 suites   4 💤
 2 files     0 ❌

Results for commit ca91a07.

♻️ This comment has been updated with latest results.


| Version | Date | Pull Request | Subject |
|:------------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 4.1.1 | 2025-11-21 | [69802](https://github.com/airbytehq/airbyte/pull/69802) | Fix custom query regex conditions |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.WordList] Use 'regular expression' instead of 'regex'.

@tolik0 tolik0 requested a review from pnilan November 21, 2025 15:43
@github-actions
Copy link
Contributor

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-phy9kuwx4-airbyte-growth.vercel.app

Built with commit ca91a07.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

Starting regression tests (filter: --modified)
Workflow run: 19618134700
Regression tests: ✅ PASSED
Report: not generated
LLM Evaluation: ⚠️ Did not run

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

Starting regression tests (filter: --modified)
Workflow run: 19618377582
Regression tests: ✅ PASSED
Report: not generated
LLM Evaluation: ⚠️ Did not run

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

Starting regression tests (filter: --modified)
Workflow run: 19618383854
Regression tests: ✅ PASSED
Report: not generated
LLM Evaluation: ⚠️ Did not run

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

Starting regression tests (filter: --modified)
Workflow run: 19618484889
Regression tests: ✅ PASSED
Report: not generated
LLM Evaluation: ⚠️ Did not run

@tolik0
Copy link
Contributor Author

tolik0 commented Nov 24, 2025

/build-connector-images

Connector Image Build Started

  • This workflow will build the connector image and run basic tests.
  • The connector image(s) will be pushed to the GitHub Container Registry.

Check job output.
Connector Image Builds job completed. See logs for details.

@tolik0 tolik0 merged commit b85b63b into master Nov 24, 2025
46 of 51 checks passed
@tolik0 tolik0 deleted the tolik0/source-google-ads/fix-custom-queries-regex-conditions branch November 24, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants