-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix(source-google-ads): Fix custom query regex conditions #69802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(source-google-ads): Fix custom query regex conditions #69802
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
|
|
|
||
| | Version | Date | Pull Request | Subject | | ||
| |:------------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | 4.1.1 | 2025-11-21 | [69802](https://github.com/airbytehq/airbyte/pull/69802) | Fix custom query regex conditions | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.WordList] Use 'regular expression' instead of 'regex'.
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit ca91a07. |
|
|
|
|
|
/build-connector-images
|
What
.*with[\s\S]*?so matches work across multiple lines.LIMITrequirement (unnecessary).regex_searchreturning an empty string ("") when no match is found, instead ofNoneas previously assumed.How
Review guide
User Impact
Can this PR be safely reverted and rolled back?