Skip to content

Conversation

@Bazger
Copy link

@Bazger Bazger commented Nov 22, 2025

SFTP Bulk: Encoding Fix has the problem of parsing other encodings except for UTF-8.

What

Paramiko SFTP encoding reading issue. SFTP Paramiko parses the stream with UTF-8 before it coming to the CSV parser

How

Reading the whole stream beforehand and parsing it with the right encoding

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from Bazger/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /run-live-tests - Runs live tests for the modified connector(s).
  • /run-regression-tests - Runs regression tests for the modified connector(s).
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

📝 Edit this welcome message.

@Bazger Bazger changed the title SFTP Bulk: Encoding Fix, has problem of parsing other encodings excep… [BUG] SFTP Bulk: Encoding Fix - enable other encodings for CSV parser Nov 22, 2025
@DanyloGL
Copy link
Collaborator

@Bazger thank you for your contribution! Could you please sign our Contributor License Agreement before we can accept your contribution.

@DanyloGL DanyloGL moved this from New PRs to Waiting CLA in 🧑‍🏭 Community Pull Requests Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting CLA

Development

Successfully merging this pull request may close these issues.

5 participants