fix(source-okta): Fix OAuth with private key PEM parsing issue #69831
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The private key string from Airbyte Cloud contains escaped newlines (\n) instead of actual newline characters, causing PyJWT to fail parsing the PEM-formatted key with 'InvalidKeyError: Could not parse the provided public key.' This fix normalizes the escaped newlines to actual newlines before passing the key to jwt.encode(), following the same pattern used in other parts of the codebase (see commit e53e290). This resolves the issue for both the Okta connector and any other connectors using OAuth with private key authentication in the connector builder. Co-Authored-By: [email protected] <[email protected]>
Contributor
Original prompt from [email protected] |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Contributor
|
Co-Authored-By: [email protected] <[email protected]>
Contributor
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 77d45c0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a critical issue where OAuth authentication with private key fails in the Okta connector (and potentially other connectors using OAuth with private key in the connector builder) with the error:
This occurs because the private key string from Airbyte Cloud contains escaped newlines (
\\n) instead of actual newline characters, causing PyJWT to fail parsing the PEM-formatted key.How
Added a normalization step in
CustomOauth2PrivateKeyAuthenticator.token()that converts escaped newlines to actual newlines before passing the private key tojwt.encode(). This follows the same pattern used elsewhere in the codebase (see commit e53e290).Review guide
airbyte-integrations/connectors/source-okta/source_okta/components.py- Review the normalization logic in thetoken()method (lines 91-93)User Impact
Positive:
Negative:
Can this PR be safely reverted and rolled back?
The change is minimal and only affects the OAuth with private key authentication flow. Reverting would simply restore the broken behavior.
Link to Devin run: https://app.devin.ai/sessions/ccfafd12c230478f82106eb1bac5de88
Requested by: @Airbyte-Support ([email protected])
Note: This fix was implemented based on error logs and pattern matching with historical fixes in the codebase. Ideally, this should be tested with an actual Okta instance using OAuth with private key authentication before merging.