fix(source-intercom): bump heartbeat timeout from 6h to 9h#73635
fix(source-intercom): bump heartbeat timeout from 6h to 9h#73635
Conversation
…6h to 9h) The companies stream uses the Intercom scroll API with client-side incremental filtering. When the cursor is stale, the connector spends extended periods fetching and filtering records without emitting any RECORD or STATE messages, triggering the platform heartbeat timeout. Only STATE and RECORD messages reset the platform heartbeat timer, so the silent filtering period causes the sync to be killed. Increasing from 6 hours to 9 hours provides sufficient headroom for the companies scroll to complete. Co-Authored-By: alfredo.garcia@airbyte.io <freddy.garcia7.fg@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
|
/bump-version
|
|
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit af91c2f. |
What
Increases the Intercom source heartbeat timeout (
maxSecondsBetweenMessages) from 21,600s (6h) to 32,400s (9h) to prevent premature sync termination on thecompaniesstream.Related: airbytehq/oncall#11198 / #72955
The
companiesstream uses the Intercom scroll API withis_client_side_incremental: true. When the cursor is stale, the connector must scroll through all companies and filter client-side — going extended periods without emitting any RECORD or STATE messages. The platform heartbeat monitor only resets on RECORD and STATE, so the silent filtering period triggers a heartbeat timeout kill.How
Two config changes in
metadata.yaml:maxSecondsBetweenMessagesfrom21600→32400dockerImageTagfrom0.13.16-rc.1→0.13.17(version bump via/bump-version)Changelog entry auto-generated in
docs/integrations/sources/intercom.md.Review guide
airbyte-integrations/connectors/source-intercom/metadata.yaml— timeout and version bumpdocs/integrations/sources/intercom.md— auto-generated changelog entryKey items for reviewer:
0.13.16-rc.1(RC) to0.13.17(GA). Confirm that shipping the timeout change as a GA release is intended.User Impact
Intercom syncs with stale
companiescursors will no longer be killed prematurely by the heartbeat monitor. No impact on syncs that are already completing within 6h.Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/77cf265ee5f1499988257947bf79b923
Requested by: @agarctfi