fix: write SSL client keystore to temp dir instead of CWD#75539
Merged
Rodi Reich Zilberman (rodireich) merged 1 commit intorodi/fix-postgres-inegration-testsfrom Mar 27, 2026
Conversation
The PKCS12 keystore for SSL client certificates was being written to the current working directory (directory=""). In Docker integration tests, the CWD is a mounted volume that may not be writable by the container's airbyte user on Linux Docker (strict bind mount permissions), causing the check connection to fail with a ConfigErrorException. Write to a temp directory instead, consistent with how the CA certificate file is already handled. https://claude.ai/code/session_0134GX4pRMvgvHHqSsWDpPEx
|
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
8d63f3e
into
rodi/fix-postgres-inegration-tests
45 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PKCS12 keystore for SSL client certificates was being written to the current working directory (directory=""). In Docker integration tests, the CWD is a mounted volume that may not be writable by the container's airbyte user on Linux Docker (strict bind mount permissions), causing the check connection to fail with a ConfigErrorException.
Write to a temp directory instead, consistent with how the CA certificate file is already handled.
https://claude.ai/code/session_0134GX4pRMvgvHHqSsWDpPEx
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?