Skip to content

fix: write SSL client keystore to temp dir instead of CWD#75539

Merged
Rodi Reich Zilberman (rodireich) merged 1 commit intorodi/fix-postgres-inegration-testsfrom
claude/fix-ci-error-75522-26sxi
Mar 27, 2026
Merged

fix: write SSL client keystore to temp dir instead of CWD#75539
Rodi Reich Zilberman (rodireich) merged 1 commit intorodi/fix-postgres-inegration-testsfrom
claude/fix-ci-error-75522-26sxi

Conversation

@rodireich
Copy link
Copy Markdown
Contributor

The PKCS12 keystore for SSL client certificates was being written to the current working directory (directory=""). In Docker integration tests, the CWD is a mounted volume that may not be writable by the container's airbyte user on Linux Docker (strict bind mount permissions), causing the check connection to fail with a ConfigErrorException.

Write to a temp directory instead, consistent with how the CA certificate file is already handled.

https://claude.ai/code/session_0134GX4pRMvgvHHqSsWDpPEx

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

The PKCS12 keystore for SSL client certificates was being written to
the current working directory (directory=""). In Docker integration
tests, the CWD is a mounted volume that may not be writable by the
container's airbyte user on Linux Docker (strict bind mount permissions),
causing the check connection to fail with a ConfigErrorException.

Write to a temp directory instead, consistent with how the CA
certificate file is already handled.

https://claude.ai/code/session_0134GX4pRMvgvHHqSsWDpPEx
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
    • /bump-progressive-rollout-version - Bumps connector version with an RC suffix (2.16.10-rc.1) for progressive rollouts (enableProgressiveRollout: true).
      • Example: /bump-progressive-rollout-version changelog="Add new feature for progressive rollout"
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown
Contributor

source-postgres Connector Test Results

 14 files  ±0   14 suites  ±0   6m 59s ⏱️ +27s
 90 tests ±0   90 ✅ +12  0 💤 ±0  0 ❌  - 12 
252 runs  ±0  252 ✅ +12  0 💤 ±0  0 ❌  - 12 

Results for commit 37f845e. ± Comparison against base commit 3d05618.

@rodireich Rodi Reich Zilberman (rodireich) marked this pull request as ready for review March 27, 2026 19:53
@rodireich Rodi Reich Zilberman (rodireich) merged commit 8d63f3e into rodi/fix-postgres-inegration-tests Mar 27, 2026
45 of 46 checks passed
@rodireich Rodi Reich Zilberman (rodireich) deleted the claude/fix-ci-error-75522-26sxi branch March 27, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants