fix: update sort order before columns to handle dropped columns in PK. Drop sort order when not-dedupe.#75546
Open
Ryan Br... (tryangul) wants to merge 2 commits intomasterfrom
Open
Conversation
…ns. Drop sort order if no longer dedupe.
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
Deploy preview for airbyte-kotlin-cdk ready! ✅ Preview Built with commit 2d31709. |
Benoit Moriceau (benmoriceau)
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
ValidationExceptionwhen deleting an Iceberg column referenced by the table's sort order. Sort orders are set at table creation and never updated, causing crashes on schema evolution.How
New
replaceSortOrderIfNeededmethod inIcebergTableSynchronizer, called before schema commits. Strips deleted columns from the sort order, clears it on Dedupe→Append, rebuilds it on PK changes.Review guide
IcebergTableSynchronizer.kt—replaceSortOrderIfNeeded+ wiringIcebergTableSynchronizerTest.kt— 4 new real-table testsUser Impact
Iceberg no longer crash when schema propagation removes a sort-order column.
Next steps
Cut connector releases and rollout
Can this PR be safely reverted and rolled back?