Skip to content

Composite primary key #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Composite primary key #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57187c6
Composite primary key
edbizarro Feb 18, 2019
77580a0
Fix condition when primary_key is a string
edbizarro Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 48 additions & 21 deletions operators/s3_to_redshift_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ class S3ToRedshiftOperator(BaseOperator):
:param incremental_key: *(optional)* The incremental key to compare
new data against the destination table
with. Only required if using a load_type of
"upsert".
"upsert". This may be either
a list or a string.
:type incremental_key: string
:param foreign_key: *(optional)* This specifies any foreign_keys
in the table and which corresponding table
Expand Down Expand Up @@ -239,20 +240,42 @@ def getS3Conn():
# and the primary key is the same.
# (e.g. Source: {"id": 1, "updated_at": "2017-01-02 00:00:00"};
# Destination: {"id": 1, "updated_at": "2017-01-01 00:00:00"})

delete_sql = \
'''
if isinstance(self.primary_key, list):
where_pk = ""
for i, item in enumerate(self.primary_key):
where_pk += """
"{rs_schema}"."{rs_table}"."{item}" = "{rs_schema}"."{rs_table}{rs_suffix}"."{item}"
""".format(
rs_schema=self.redshift_schema,
rs_table=self.table,
rs_suffix=self.temp_suffix,
item=item,
)
if i != (len(self.primary_key) - 1):
where_pk += " AND "
else:
where_pk = '"{rs_schema}"."{rs_table}"."{rs_pk}" = "{rs_schema}"."{rs_table}{rs_suffix}"."{rs_pk}"'.format(
rs_schema=self.redshift_schema,
rs_table=self.table,
rs_pk=self.primary_key,
rs_suffix=self.temp_suffix,
rs_ik=self.incremental_key,
)

delete_sql = """
DELETE FROM "{rs_schema}"."{rs_table}"
USING "{rs_schema}"."{rs_table}{rs_suffix}"
WHERE "{rs_schema}"."{rs_table}"."{rs_pk}" =
"{rs_schema}"."{rs_table}{rs_suffix}"."{rs_pk}"
WHERE {where_pk}
AND "{rs_schema}"."{rs_table}{rs_suffix}"."{rs_ik}" >=
"{rs_schema}"."{rs_table}"."{rs_ik}"
'''.format(rs_schema=self.redshift_schema,
rs_table=self.table,
rs_pk=self.primary_key,
rs_suffix=self.temp_suffix,
rs_ik=self.incremental_key)
""".format(
rs_schema=self.redshift_schema,
rs_table=self.table,
rs_pk=self.primary_key,
rs_suffix=self.temp_suffix,
rs_ik=self.incremental_key,
where_pk=where_pk,
)

# Delete records from the source table where the incremental_key
# is greater than or equal to the incremental_key of the destination
Expand All @@ -264,19 +287,20 @@ def getS3Conn():
# (e.g. Source: {"id": 1, "updated_at": "2017-01-01 00:00:00"};
# Destination: {"id": 1, "updated_at": "2017-01-02 00:00:00"})

delete_confirm_sql = \
'''
delete_confirm_sql = """
DELETE FROM "{rs_schema}"."{rs_table}{rs_suffix}"
USING "{rs_schema}"."{rs_table}"
WHERE "{rs_schema}"."{rs_table}{rs_suffix}"."{rs_pk}" =
"{rs_schema}"."{rs_table}"."{rs_pk}"
WHERE {where_pk}
AND "{rs_schema}"."{rs_table}"."{rs_ik}" >=
"{rs_schema}"."{rs_table}{rs_suffix}"."{rs_ik}"
'''.format(rs_schema=self.redshift_schema,
rs_table=self.table,
rs_pk=self.primary_key,
rs_suffix=self.temp_suffix,
rs_ik=self.incremental_key)
""".format(
rs_schema=self.redshift_schema,
rs_table=self.table,
rs_pk=self.primary_key,
rs_suffix=self.temp_suffix,
rs_ik=self.incremental_key,
where_pk=where_pk,
)

append_sql = \
'''
Expand Down Expand Up @@ -371,7 +395,10 @@ def create_if_not_exists(self, schema, pg_hook, temp=False):
sk = ''

if self.primary_key:
pk = ', primary key("{0}")'.format(self.primary_key)
if isinstance(self.primary_key, str):
pk = ", primary key({0})".format(self.primary_key)
elif isinstance(self.primary_key, list):
pk = ", primary key({0})".format(", ".join(self.primary_key))

if self.foreign_key:
if isinstance(self.foreign_key, list):
Expand Down