Open
Conversation
JamesDawson
reviewed
Nov 2, 2022
| displayName: 'Publish documentation to GitHub Pages' | ||
| condition: and(succeeded(), or(variables['Endjin.ForceDocPublish'], eq(variables['GitVersion.PreReleaseTag'], ''))) No newline at end of file | ||
| condition: and(succeeded(), or(variables['Endjin.ForceDocPublish'], eq(variables['GitVersion.PreReleaseTag'], ''))) | ||
| compileTasksServiceConnection: endjin-acr-reader No newline at end of file |
There was a problem hiding this comment.
We need to look at the customisations in this YAML file:
- Check whether they are still needed? (e.g. installing .NET 6)
- Check whether the extensibility points it uses are available in the scripted build version of the template (e.g.
postSpecs)
Contributor
There was a problem hiding this comment.
I think this was one of the earliest projects to use .NET 6. (We did it to find out whether it gave a perf boost, which it did.)
I would expect we no longer need special handling for that.
We want to keep the benchmark run and the docfx build.
JamesDawson
reviewed
Nov 2, 2022
| displayName: 'Publish documentation to GitHub Pages' | ||
| condition: and(succeeded(), or(variables['Endjin.ForceDocPublish'], eq(variables['GitVersion.PreReleaseTag'], ''))) No newline at end of file | ||
| condition: and(succeeded(), or(variables['Endjin.ForceDocPublish'], eq(variables['GitVersion.PreReleaseTag'], ''))) | ||
| compileTasksServiceConnection: endjin-acr-reader No newline at end of file |
There was a problem hiding this comment.
I think moving line 69 earlier in the file, before the customisations, would make it easier to read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.