Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the test framework from SpecFlow (which is effectively defunct) to Reqnroll, its successor. The migration is straightforward and complete, updating all namespace references, package dependencies, and removing SpecFlow-specific workarounds.
Key changes:
- Updated all using statements from
TechTalk.SpecFlowtoReqnrollacross 13 test step definition files - Replaced
Corvus.Testing.SpecFlow.NUnitpackage withCorvus.Testing.ReqnRoll.NUnitv4.0.5 - Removed SpecFlow-specific compiler warning suppressions (SA1633, SA1649) and manual Compile Update entries from the project file
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/Ais.Net.Specs/Ais/Net/Specs/SentenceLayerSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/ParsePayloadSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/NmeaStreamParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/NmeaLineToAisStreamAdapterSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/NmeaAisMessageStreamProcessorBindings.cs | Updated namespace to Reqnroll and corrected copyright header filename |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/NmeaAisBitVectorParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/AisStringsSpecsSteps.cs | Updated namespace to Reqnroll and fixed typo in comment ("is" → "it") |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/AisMessageTypes/StaticDataReportParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/AisMessageTypes/StaticAndVoyageRelatedDataParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/AisMessageTypes/PositionReportExtendedClassBParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/AisMessageTypes/PositionReportClassBParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/AisMessageTypes/PositionReportClassAParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais/Net/Specs/AisMessageTypes/LongRangeAisBroadcastParserSpecsSteps.cs | Updated namespace from TechTalk.SpecFlow to Reqnroll |
| Solutions/Ais.Net.Specs/Ais.Net.Specs.csproj | Updated package reference to Reqnroll variant, removed SpecFlow-specific NoWarn suppressions and Compile Update entries |
| .gitignore | Updated comment from SpecFlow to Reqnroll |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage Summary Report - Linux (net8.0)Summary
CoverageNo assemblies have been covered. |
Code Coverage Summary Report - Windows (net8.0)Summary
CoverageAis.Net - 90%
Ais.Net.Specs - 99.2%
|
Code Coverage Summary Report - Windows (net481)Summary
CoverageNo assemblies have been covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #188
SpecFlow is effectively defunct. But Reqnroll is effectively the same project by another name, so we've moved over to it.