Generalized variable substitution for LoopExecutor#145
Merged
whotwagner merged 3 commits intoait-testbed:developmentfrom Feb 7, 2025
Merged
Generalized variable substitution for LoopExecutor#145whotwagner merged 3 commits intoait-testbed:developmentfrom
whotwagner merged 3 commits intoait-testbed:developmentfrom
Conversation
Co-authored-by: Thorina Boenke <68156005+thorinaboenke@users.noreply.github.com>
thorinaboenke
approved these changes
Feb 7, 2025
whotwagner
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the LoopExecutor only substituted variables in the
cmdfield. This was insufficient for commands with additional attributes, which may also contain placeholders.This PR enhances the LoopExecutor to support generalized variable substitution for all string attributes in commands.
Units tests were written with the help of the sleep command to make sure it works with its
secondsfield. It was also successfully tested with the incoming browser executor. To manually test it with the sleep command, here is an example playbook: