Open
Conversation
Signed-off-by: aiyijing <aiyijing@live.com>
spowelljr
suggested changes
Jun 17, 2024
| } | ||
| latestSemVer, err := semver.ParseTolerant(latestVersion) | ||
| if err != nil { | ||
| exit.Error(reason.InetVersionUnavailable, "Unable to parse latest version", err) |
There was a problem hiding this comment.
Same as above:
Should use a different reason or create a new one, this reason is related to the internet being unavailable, but this failure is related to a version parsing error.
|
We'll need to flesh this out a bit more, I think it would be good to confirm with the user if they want to upgrade and provide a link the release notes so they can decide if they want to upgrade or not. Such as the typical |
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.