Skip to content

Don't use non-standard ACCESSPERMS macro#42

Open
alyssais wants to merge 1 commit intoaja-video:mainfrom
alyssais:ACCESSPERMS
Open

Don't use non-standard ACCESSPERMS macro#42
alyssais wants to merge 1 commit intoaja-video:mainfrom
alyssais:ACCESSPERMS

Conversation

@alyssais
Copy link
Copy Markdown

@alyssais alyssais commented Jan 3, 2025

This macro is non-standard, and is not defined by e.g. musl libc. It's just a define for 0777, so just use that instead.

This macro is non-standard, and is not defined by e.g. musl libc.
It's just a define for 0777, so just use that instead.
@paulh-aja
Copy link
Copy Markdown
Collaborator

After reviewing this PR with other software engineers on the internal AJA NTV2 team, a suggestion was made to do something like this:

#ifndef ACCESSPERMS
#define ACCESSPERMS 0777
#endif

And then leave the rest of the code as it was prior to the change in this PR.

@alyssais
Copy link
Copy Markdown
Author

alyssais commented Jan 9, 2025

Where would make the most sense to define that? In some header, or in this file directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants