Don't use non-standard ACCESSPERMS macro#42
Open
alyssais wants to merge 1 commit intoaja-video:mainfrom
Open
Conversation
This macro is non-standard, and is not defined by e.g. musl libc. It's just a define for 0777, so just use that instead.
13 tasks
Collaborator
|
After reviewing this PR with other software engineers on the internal AJA NTV2 team, a suggestion was made to do something like this: And then leave the rest of the code as it was prior to the change in this PR. |
Author
|
Where would make the most sense to define that? In some header, or in this file directly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This macro is non-standard, and is not defined by e.g. musl libc. It's just a define for 0777, so just use that instead.