Fix audio clock register low mask values#50
Open
dalkhimov88 wants to merge 1 commit intoaja-video:mainfrom
Open
Fix audio clock register low mask values#50dalkhimov88 wants to merge 1 commit intoaja-video:mainfrom
dalkhimov88 wants to merge 1 commit intoaja-video:mainfrom
Conversation
dalkhimov88
commented
May 8, 2025
Author
dalkhimov88
left a comment
dalkhimov88
left a comment
There was a problem hiding this comment.
Fixes #49: 64-bit audio clock values incorrectly split into 32 bit low and high, resulting in data loss
Collaborator
|
@davids635 Is a mask of the 64-bit value strictly needed here? We omit the mask in the analogous Win/Mac driver code (closed-source). |
Collaborator
|
@dalkhimov88 Would you mind pulling in the latest main branch changes to your branch? This code was cleaned up a bit, to perform only a single call to GetAudioClock at the top of the function. After you've done that we'll merge this. |
Collaborator
|
@dalkhimov88 Please resolve the current merge conflicts and we will get this merged. Good find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.