Properly make CNTV2DeviceScanner::GetDeviceInfoList a class method#57
Open
lukegb wants to merge 1 commit intoaja-video:mainfrom
Conversation
lukegb
force-pushed
the
this-is-actually-a-class-method-and-i-dont-understand-how-this-compiles-for-anyone
branch
from
277b687 to
95160bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the header file, this is a static member of the class, but in the implementation cpp it's just a free function.
I don't really understand how this compiles for anyone as is, but given this function is deprecated anyway I'm not too uptight about fixing it - this is an upstreamed version of the patch I'm using in nixpkgs for libajantv2 since it doesn't build there without, possibly since we have stricter-than-standard build flags and most likely a newer compiler toolchain.