Skip to content

Conversation

@salmanul
Copy link

Issue #, if available:

Description of changes: Enhance beautify method using requestAnimationFrame for handling large textual contents, Current enhancement will reduce the blocking of main thread while beautifying in the editor.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andrewnester
Copy link
Contributor

We recently introduced new way of configuring beautify formatting options, so it can be better to move it there
#4697

Also please resolve the conflicts

@salmanul
Copy link
Author

K, it can be moved over there.
I will update the PR once it is resolved.

@salmanul salmanul force-pushed the feature/non-blocking-beautify-ext branch from fbe1219 to b61765f Compare May 13, 2022 04:19
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (33cf1c6) to head (ecb35a8).
Report is 924 commits behind head on master.

Files with missing lines Patch % Lines
lib/ace/ext/beautify.js 43.75% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4623      +/-   ##
==========================================
- Coverage   71.19%   71.18%   -0.01%     
==========================================
  Files         553      553              
  Lines       55598    55611      +13     
  Branches    10392    10394       +2     
==========================================
+ Hits        39584    39588       +4     
- Misses      16014    16023       +9     
Flag Coverage Δ
unittests 71.18% <43.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants