Fix trailing slash handling in directory tests#1178
Open
mcollard0 wants to merge 1 commit intoajeetdsouza:mainfrom
Open
Fix trailing slash handling in directory tests#1178mcollard0 wants to merge 1 commit intoajeetdsouza:mainfrom
mcollard0 wants to merge 1 commit intoajeetdsouza:mainfrom
Conversation
Resolves issue where z mydir/ fails even when mydir exists Shell built-in directory tests can fail when paths have trailing slashes. This fix strips trailing slashes before the directory test while preserving the original path for cd. Changes: Fish, Bash, Zsh, POSIX, and Tcsh templates now strip trailing slashes before directory tests
Author
|
Initial tests are conclusive. No evidence of cancer is not evidence of no cancer. Further testing by peers is requested. ~/.local/bin/zoxide init fish | source cd / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue where `z mydir/` fails even when mydir exists.
Shell built-in directory tests (`[ -d path/ ]`) can fail when paths have trailing slashes. This fix strips trailing slashes before the directory test while preserving the original path for cd.
Changes
Key Design Decisions