Merged
Conversation
|
✅ Docker images built successfully for all platforms! CI run: https://github.com/ajilach/clamav-rest/actions/runs/22859325418 |
arizon-dread
approved these changes
Mar 9, 2026
Collaborator
arizon-dread
left a comment
There was a problem hiding this comment.
Great contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to use Go version 1.26.0 and ensures that the Go version is consistently sourced from
go.modacross all build environments. The changes improve maintainability by eliminating hardcoded Go versions and aligning Docker, CI, and Nix builds with the version specified ingo.mod.Go version management improvements:
go.modto specify Go version 1.26.0, replacing the previous 1.25 version.DockerfileandDockerfile.testto use a build argumentGO_VERSION, which defaults to 1.26.0 and is now dynamically set instead of hardcoded. [1] [2]docker-compose.test.ymlto pass theGO_VERSIONbuild argument from the environment, ensuring test containers use the correct Go version.CI/CD workflow enhancements:
.github/workflows/ci.yamlto extract the Go version fromgo.modand set it as an environment variable for build steps, ensuring CI uses the correct Go version. [1] [2] [3]Nix build improvements:
default.nixto read the Go version fromgo.modand select the appropriate Go package fromnixpkgs, eliminating manual version updates.