Skip to content

Sync Go version from go.mod#101

Merged
arizon-dread merged 1 commit intomasterfrom
go-version-sync
Mar 9, 2026
Merged

Sync Go version from go.mod#101
arizon-dread merged 1 commit intomasterfrom
go-version-sync

Conversation

@davosian
Copy link
Contributor

@davosian davosian commented Mar 9, 2026

This pull request updates the project to use Go version 1.26.0 and ensures that the Go version is consistently sourced from go.mod across all build environments. The changes improve maintainability by eliminating hardcoded Go versions and aligning Docker, CI, and Nix builds with the version specified in go.mod.

Go version management improvements:

  • Updated go.mod to specify Go version 1.26.0, replacing the previous 1.25 version.
  • Modified both Dockerfile and Dockerfile.test to use a build argument GO_VERSION, which defaults to 1.26.0 and is now dynamically set instead of hardcoded. [1] [2]
  • Updated docker-compose.test.yml to pass the GO_VERSION build argument from the environment, ensuring test containers use the correct Go version.

CI/CD workflow enhancements:

  • Changed .github/workflows/ci.yaml to extract the Go version from go.mod and set it as an environment variable for build steps, ensuring CI uses the correct Go version. [1] [2] [3]

Nix build improvements:

  • Updated default.nix to read the Go version from go.mod and select the appropriate Go package from nixpkgs, eliminating manual version updates.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

✅ Docker images built successfully for all platforms!

CI run: https://github.com/ajilach/clamav-rest/actions/runs/22859325418

@davosian davosian requested a review from arizon-dread March 9, 2026 15:04
@davosian davosian marked this pull request as ready for review March 9, 2026 15:05
Copy link
Collaborator

@arizon-dread arizon-dread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution!

@arizon-dread arizon-dread merged commit 7572f30 into master Mar 9, 2026
6 checks passed
@davosian davosian deleted the go-version-sync branch March 10, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants