Skip to content

Make the cancel button work#24

Open
Caraxi wants to merge 2 commits intoajkhoury:masterfrom
Caraxi:workingCancel
Open

Make the cancel button work#24
Caraxi wants to merge 2 commits intoajkhoury:masterfrom
Caraxi:workingCancel

Conversation

@Caraxi
Copy link
Contributor

@Caraxi Caraxi commented Jul 28, 2021

Cancel search when the cancel button is pressed.

@Caraxi
Copy link
Contributor Author

Caraxi commented Mar 1, 2022

Any updates?

@ajkhoury
Copy link
Owner

ajkhoury commented Mar 1, 2022

Maybe I am misinterpreting the code, but what is the point of the extra or in cancelled = cancelled || user_cancelled(); ? Could you not simply do cancelled = user_cancelled();? Or better yet something like the following?

 if (user_cancelled()) {
    cancelled = true;
    break;
}

@Caraxi
Copy link
Contributor Author

Caraxi commented Jul 13, 2022

I don't remember why I did it like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants