Skip to content

Conversation

@cloud-j-luna
Copy link
Member

📝 Description

[Explain what this PR does in 2-3 sentences. Include context about the feature or problem being solved]

🔧 Purpose of the Change

  • New feature implementation
  • Bug fix
  • Documentation update
  • Code refactoring
  • Dependency upgrade
  • Other: [specify]

📌 Related Issues

  • Closes #ISSUE_NUMBER
  • References #ISSUE_NUMBER

✅ Checklist

  • I've updated relevant documentation
  • Code follows Akash Network's style guide
  • I've added/updated relevant unit tests
  • Dependencies have been properly updated
  • I agree and adhered to the Contribution Guidelines

📎 Notes for Reviewers

[Include any additional context, architectural decisions, or specific areas to focus on]

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

This change introduces support for the AutomountServiceAccountToken field across the SDLv2 build pipeline. The field is added to the protobuf service schema, propagated through the Go struct definition, and copied by the group builders into generated manifest service parameters.

Changes

Cohort / File(s) Summary
Protocol Buffer Schema
proto/provider/akash/manifest/v2beta3/service.proto
Added automount_service_account_token boolean field (field 11) to ServiceParams message with gogoproto annotations for JSON and YAML serialization
Go Struct Definition
go/sdl/v2.go
Added AutomountServiceAccountToken boolean field to v2ServiceParams struct with yaml:"automountServiceAccountToken,omitempty" tag
Go Builders
go/sdl/groupBuilder_v2.go, go/sdl/groupBuilder_v2_1.go
Propagates AutomountServiceAccountToken from service parameters to manifest service parameters in both builder implementations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 From proto to builder, the token takes flight,
Automounting with such delight,
Through SDLv2 the field does dance,
Service accounts get their chance! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template placeholder with no actual content filled in. All required sections are either empty or unchecked, providing no meaningful information about the feature, purpose, or implementation. Fill in the description section with what the PR does, check the appropriate purpose checkbox, add related issue numbers, complete the checklist items, and include notes for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding automount service account token support to deployments, which aligns with the code changes across four files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/automount-service-account-token


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc07687 and e180930.

⛔ Files ignored due to path filters (1)
  • go/manifest/v2beta3/service.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (4)
  • go/sdl/groupBuilder_v2.go
  • go/sdl/groupBuilder_v2_1.go
  • go/sdl/v2.go
  • proto/provider/akash/manifest/v2beta3/service.proto
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: test
  • GitHub Check: coverage
  • GitHub Check: proto
  • GitHub Check: go
  • GitHub Check: breakage
🔇 Additional comments (4)
proto/provider/akash/manifest/v2beta3/service.proto (1)

42-45: LGTM!

The new automount_service_account_token field is correctly added with proper field numbering (11) and appropriate gogoproto annotations for JSON/YAML serialization. The omitempty tag aligns with standard practices for boolean fields.

go/sdl/v2.go (1)

168-171: LGTM!

The AutomountServiceAccountToken field is correctly added to v2ServiceParams with consistent YAML tagging that matches the proto definition. The omitempty tag is appropriate for boolean fields.

go/sdl/groupBuilder_v2_1.go (1)

124-125: LGTM!

The AutomountServiceAccountToken field is correctly propagated from service params to manifest params. The assignment is properly guarded by the svc.Params != nil check.

go/sdl/groupBuilder_v2.go (1)

114-115: LGTM!

The implementation is consistent with groupBuilder_v2_1.go, correctly propagating the AutomountServiceAccountToken field within the params nil check.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants