Skip to content

fix!: moved ErrInternal to the chain-sdk #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vertex451 wants to merge 8 commits into
base: main
Choose a base branch
from
+11 −14
Open

fix!: moved ErrInternal to the chain-sdk #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6394498
fix: replaced cerrors.Register with cerrors.RegisterWithGRPCCode
vertex451 Jan 5, 2026
c997a3c
chore: updated changelog
vertex451 Jan 5, 2026
a9bcd5a
Merge branch 'main' of github.com:akash-network/node into artem/fix/5…
vertex451 Jan 5, 2026
2d9844e
Merge branch 'main' of github.com:akash-network/node into artem/fix/5…
vertex451 Jan 5, 2026
4f5e093
chore: fmt
vertex451 Jan 5, 2026
2a00c30
refactor: moved ErrInternal to the chain-sdk
vertex451 Jan 7, 2026
577d71e
Merge branch 'main' of github.com:akash-network/node into artem/fix/5…
vertex451 Jan 9, 2026
b92d711
refactor: updated pkg.akt.dev/go version
vertex451 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,5 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Bug Fixes

* Fix bug in ditribution and querying rewards

* Moved x/provider/handler.ErrInternal to the chain-sdk/go/node/provider/v1beta4 package.
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ require (
google.golang.org/grpc v1.75.0
gopkg.in/yaml.v3 v3.0.1
gotest.tools/v3 v3.5.2
pkg.akt.dev/go v0.1.6
pkg.akt.dev/go v0.1.9-0.20260109003838-508f70669a8c
Copy link
Contributor Author

@vertex451 vertex451 Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used not released commit here to pass the CI.
I am not aware of the releasing strategy, if you need anything else to finish that PR - let me know
CC: @troian

pkg.akt.dev/go/cli v0.1.4
pkg.akt.dev/go/sdl v0.1.1
)
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3284,8 +3284,8 @@ nhooyr.io/websocket v1.8.11 h1:f/qXNc2/3DpoSZkHt1DQu6rj4zGC8JmkkLkWss0MgN0=
nhooyr.io/websocket v1.8.11/go.mod h1:rN9OFWIUwuxg4fR5tELlYC04bXYowCP9GX47ivo2l+c=
pgregory.net/rapid v0.5.5 h1:jkgx1TjbQPD/feRoK+S/mXw9e1uj6WilpHrXJowi6oA=
pgregory.net/rapid v0.5.5/go.mod h1:PY5XlDGj0+V1FCq0o192FdRhpKHGTRIWBgqjDBTrq04=
pkg.akt.dev/go v0.1.6 h1:3wkDfEMWwe4ziUfNq6wUxRFSgYsL/uYF/uZgVfdet/U=
pkg.akt.dev/go v0.1.6/go.mod h1:GUDt3iohVNbt8yW4P5Q0D05zoMs2NXaojF2ZBZgfWUQ=
pkg.akt.dev/go v0.1.9-0.20260109003838-508f70669a8c h1:e0eh3GPQ7y4IIx7Pigq2XjtScvzN96wmsfsunsjwl3s=
pkg.akt.dev/go v0.1.9-0.20260109003838-508f70669a8c/go.mod h1:GUDt3iohVNbt8yW4P5Q0D05zoMs2NXaojF2ZBZgfWUQ=
pkg.akt.dev/go/cli v0.1.4 h1:wFPegnPwimWHi0v5LN6AnWZnwtwpnD6mb7Dp1HSuzlw=
pkg.akt.dev/go/cli v0.1.4/go.mod h1:ZLqHZcq+D/8a27WTPYhmfCm2iGbNicWV1AwOhdspJ4Y=
pkg.akt.dev/go/sdl v0.1.1 h1:3CcAqWeKouFlvUSjQMktWLDqftOjn4cBX37TRFT7BRM=
Expand Down
4 changes: 2 additions & 2 deletions x/provider/handler/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ func TestProviderDeleteExisting(t *testing.T) {

res, err := suite.handler(suite.ctx, deleteMsg)
require.Nil(t, res)
require.EqualError(t, err, "NOTIMPLEMENTED: "+handler.ErrInternal.Error())
require.True(t, errors.Is(err, handler.ErrInternal))
require.EqualError(t, err, "NOTIMPLEMENTED: "+types.ErrInternal.Error())
require.True(t, errors.Is(err, types.ErrInternal))

t.Run("ensure event created", func(_ *testing.T) {
// TODO: this should emit a ProviderDelete
Expand Down
13 changes: 4 additions & 9 deletions x/provider/handler/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package handler
import (
"context"

errorsmod "cosmossdk.io/errors"
sdkerrors "cosmossdk.io/errors"

sdk "github.com/cosmos/cosmos-sdk/types"
types "pkg.akt.dev/go/node/provider/v1beta4"
Expand All @@ -12,11 +12,6 @@ import (
"pkg.akt.dev/node/x/provider/keeper"
)

var (
// ErrInternal defines registered error code for internal error
ErrInternal = errorsmod.Register(types.ModuleName, 10, "internal error")
)

type msgServer struct {
provider keeper.IKeeper
market mkeeper.IKeeper
Expand Down Expand Up @@ -44,7 +39,7 @@ func (ms msgServer) CreateProvider(goCtx context.Context, msg *types.MsgCreatePr
}

if err := ms.provider.Create(ctx, types.Provider(*msg)); err != nil {
return nil, ErrInternal.Wrapf("err: %v", err)
return nil, types.ErrInternal.Wrapf("err: %v", err)
}

return &types.MsgCreateProviderResponse{}, nil
Expand All @@ -65,7 +60,7 @@ func (ms msgServer) UpdateProvider(goCtx context.Context, msg *types.MsgUpdatePr
}

if err := ms.provider.Update(ctx, types.Provider(*msg)); err != nil {
return nil, errorsmod.Wrapf(ErrInternal, "err: %v", err)
return nil, sdkerrors.Wrapf(types.ErrInternal, "err: %v", err)
}

return &types.MsgUpdateProviderResponse{}, nil
Expand All @@ -84,5 +79,5 @@ func (ms msgServer) DeleteProvider(goCtx context.Context, msg *types.MsgDeletePr
}

// TODO: cancel leases
return nil, ErrInternal.Wrap("NOTIMPLEMENTED")
return nil, types.ErrInternal.Wrap("NOTIMPLEMENTED")
}
Loading