Open
Conversation
Owner
|
Hey @Stelchenko, thanks for your contribution, and nice find We need to consider an alternative solution since modifying 9 to D is a significant breaking change. Also, we may have the same problem if someone wants to indicate that the only accepted digit is D, but the user could type a number instead. (I need to test to make sure) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I came across the fact that if I need a phone mask for India (+91), the library will allow me to enter a different code (for example, +31), because it believes that 9 is any digit. By changing the DIGITS constant to 'D', we will be able to hard-set the mask, which will contain any numbers.
I also changed the tests and the readme to match the DIGITS = 'D'