refactor(MaskedTextInput): optimize state management and value updates#319
Open
AndreyPassos wants to merge 2 commits intoakinncar:mainfrom
Open
refactor(MaskedTextInput): optimize state management and value updates#319AndreyPassos wants to merge 2 commits intoakinncar:mainfrom
AndreyPassos wants to merge 2 commits intoakinncar:mainfrom
Conversation
AndreyPassos
commented
Oct 16, 2025
AndreyPassos
commented
- Replace multiple state updates with a single ref to track latest values
- Add requestAnimationFrame and setTimeout for efficient value emission
- Remove unnecessary state for unmaskedValue and initial render check
- Clean up animation frame and timeout handlers in useEffect cleanup
…havior - Add tests for textBold, textItalic, and textDecoration props - Verify onChangeText is called with correct values - Ensure onChangeText is not called on mount
- Replace multiple state updates with a single ref to track latest values - Add requestAnimationFrame and setTimeout for efficient value emission - Remove unnecessary state for unmaskedValue and initial render check - Clean up animation frame and timeout handlers in useEffect cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.