Skip to content

fix: use slide prop #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+51 −5
Open

fix: use slide prop #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a36ee7
fix: use slide prop to render slider container
enriquebeta6 May 19, 2022
b724c10
docs: add example of Custom Slider Container
enriquebeta6 May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/demos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import CustomPaging from "../examples/CustomPaging";
import CustomSlides from "../examples/CustomSlides";
import AsNavFor from "../examples/AsNavFor";
import AppendDots from "../examples/AppendDots";
import CustomSliderContainer from "../examples/CustomSliderContainer";

export default class App extends React.Component {
render() {
Expand Down Expand Up @@ -59,6 +60,7 @@ export default class App extends React.Component {
<CustomPaging />
<CustomArrows />
<CustomSlides />
<CustomSliderContainer />
<PreviousNextMethods />
<DynamicSlides />
<VerticalMode />
Expand Down
40 changes: 40 additions & 0 deletions examples/CustomSliderContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import React, { Component } from "react";
import Slider from "../src/slider";

export default class CustomSliderContainer extends Component {
render() {
const settings = {
dots: true,
slide: "section",
infinite: true,
speed: 500,
slidesToShow: 1,
slidesToScroll: 1
};
return (
<div>
<h2>Custom Slider Container</h2>
<Slider {...settings}>
<div>
<h3>1</h3>
</div>
<div>
<h3>2</h3>
</div>
<div>
<h3>3</h3>
</div>
<div>
<h3>4</h3>
</div>
<div>
<h3>5</h3>
</div>
<div>
<h3>6</h3>
</div>
</Slider>
</div>
);
}
}
14 changes: 9 additions & 5 deletions src/inner-slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@ export class InnerSlider extends React.Component {
};
checkImagesLoad = () => {
let images =
(this.list && this.list.querySelectorAll &&
(this.list &&
this.list.querySelectorAll &&
this.list.querySelectorAll(".slick-slide img")) ||
[];
let imagesCount = images.length,
Expand Down Expand Up @@ -643,7 +644,7 @@ export class InnerSlider extends React.Component {
"targetSlide",
"useCSS"
]);
const { pauseOnHover } = this.props;
const { pauseOnHover, slide = "div" } = this.props;
trackProps = {
...trackProps,
onMouseEnter: pauseOnHover ? this.onTrackOver : null,
Expand Down Expand Up @@ -749,8 +750,11 @@ export class InnerSlider extends React.Component {
listProps = { className: "slick-list" };
innerSliderProps = { className };
}
return (
<div {...innerSliderProps}>

return React.createElement(
slide,
innerSliderProps,
<>
{!this.props.unslick ? prevArrow : ""}
<div ref={this.listRefHandler} {...listProps}>
<Track ref={this.trackRefHandler} {...trackProps}>
Expand All @@ -759,7 +763,7 @@ export class InnerSlider extends React.Component {
</div>
{!this.props.unslick ? nextArrow : ""}
{!this.props.unslick ? dots : ""}
</div>
</>
);
};
}