Add bookmark support. #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
requested changes
Jan 10, 2024
Owner
akirk
left a comment
akirk
left a comment
There was a problem hiding this comment.
Similar to #63 I really appreciate the work and idea to add support for this but I don't see storing this in user meta as sustainable. Can we also do this as a filter for now so that you can get this functionality running until we have an implementation using taxonomies?
toolstack
force-pushed
the
add-bookmarks
branch
from
4b24480 to
57fad49
Compare
toolstack
force-pushed
the
add-bookmarks
branch
from
57fad49 to
c1af61c
Compare
Contributor
Author
|
Converted to terms. |
Contributor
|
This would be great, anything holding this back @toolstack ? |
Contributor
Author
|
Not that I know of other than it looks like it needs an update to resolve the conflicts. |
Contributor
Author
|
Took a closer look, looks like somethings have changed (like the permissions) that need to be updated in the PR as well. @akirk is there any interest in actually merging this? If so I'll make the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.