Make sure tiles produced by run_prominence.py have correct data type#47
Merged
akirmse merged 1 commit intoakirmse:masterfrom Oct 16, 2025
Merged
Make sure tiles produced by run_prominence.py have correct data type#47akirmse merged 1 commit intoakirmse:masterfrom
run_prominence.py have correct data type#47akirmse merged 1 commit intoakirmse:masterfrom
Conversation
geopanda1
changed the title
run_prominence.py have correct data typerun_prominence.py have correct data type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
when running
run_prominence.pywith custom data, creating the tiles could preserve (incompatible) data types from the source files. This happens for example when running it on SRTM tiles downloaded from here https://dwtkns.com/srtm/, which come as Int16.Explicitly setting the data type in the call to gdal translate could solve this. Some of the other
*_prominence.pyscripts already apply the same option.Kind regards
Andreas