Video CLI allow configuration of generateVideo parameters via JSON #1220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to add more complex support to the video CLI.
Problem Statement
The current implementation of the video CLI unnecessarily restricts the ability to configure the generateVideo pipeline to a single sequence.
Proposed Solution
Allowing more direct configuration of the generateVideo() parameters by taking the path to a JSON (or JSONC) file as an argument opens up much greater possibilities. The JSON files are the full Parameters type schema from generate-video.ts. This means the schema is well defined and should not require maintenance for minor schema changes down the line.
These JSON files are not the easiest to handwrite, but the bulk of the definition can be omitted and populated by default values driven by the application settings. The expectation is that once a user has their own template it should really only take changes to the Sequences, and a few other demo specific properties.
Current PR State
The PR currently has a barebones demonstration of what an implementation could look like. Looking for feedback before committing further to this approach