Skip to content

Conversation

@sid2934
Copy link

@sid2934 sid2934 commented Oct 9, 2025

The goal of this pull request is to add more complex support to the video CLI.

Problem Statement

The current implementation of the video CLI unnecessarily restricts the ability to configure the generateVideo pipeline to a single sequence.

Proposed Solution

Allowing more direct configuration of the generateVideo() parameters by taking the path to a JSON (or JSONC) file as an argument opens up much greater possibilities. The JSON files are the full Parameters type schema from generate-video.ts. This means the schema is well defined and should not require maintenance for minor schema changes down the line.

These JSON files are not the easiest to handwrite, but the bulk of the definition can be omitted and populated by default values driven by the application settings. The expectation is that once a user has their own template it should really only take changes to the Sequences, and a few other demo specific properties.

Current PR State

The PR currently has a barebones demonstration of what an implementation could look like. Looking for feedback before committing further to this approach

@sid2934
Copy link
Author

sid2934 commented Oct 9, 2025

My apologies for not opening a discussion thread before creating a draft PR. I missed that in my read through of the Contribution guide. I am happy to pick up conversation over there if you would prefer. Just let me know.

@sid2934
Copy link
Author

sid2934 commented Oct 14, 2025

@akiver hoping to get some attention on this or the discussion. Please let me know what the best path forward is.

@akiver akiver force-pushed the main branch 2 times, most recently from 1194c73 to 2dd8515 Compare November 18, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant