feat: exposing custom metrics #1245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
reviewed
Jan 13, 2026
Contributor
octonato
left a comment
octonato
left a comment
There was a problem hiding this comment.
Looking good, but Vale is complaining.
patriknw
reviewed
Jan 14, 2026
| private static final Counter createdShoppingCarts = Counter.builder() // <1> | ||
| .name("shopping_cart_created_counter") | ||
| .help("Total shopping cart created") | ||
| .register(); |
Contributor
There was a problem hiding this comment.
You raise the question of using the static registry in https://github.com/lightbend/akka-runtime/issues/4664#issuecomment-3744130904
Is the static registry the same as the one that the runtime is using?
If we use the same registry, is there a risk that users could tamper with the runtime metrics? Such as deleting metrics, overwriting accidentally or on purpose?
Static things are typically problematic in tests, but perhaps this is not intended to be tested?
Contributor
|
Instead of using the Prometheus API, we should switch to using the OpenTelemetry APIs. This would also enable users to include instrumentation for other libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: https://github.com/lightbend/akka-runtime/issues/4664