Skip to content

Comments

Downgrade VirtualPathContainer RemoveChild log from Warning to Debug#8048

Merged
Aaronontheweb merged 2 commits intoakkadotnet:devfrom
apoorvdarshan:fix/downgrade-remove-non-child-log-to-debug
Feb 24, 2026
Merged

Downgrade VirtualPathContainer RemoveChild log from Warning to Debug#8048
Aaronontheweb merged 2 commits intoakkadotnet:devfrom
apoorvdarshan:fix/downgrade-remove-non-child-log-to-debug

Conversation

@apoorvdarshan
Copy link
Contributor

Summary

  • Changed Log.Warning to Log.Debug in both VirtualPathContainer.RemoveChild overloads
  • TryRemove returning false on the ConcurrentDictionary simply means "already removed" — not an error condition
  • Eliminates noisy warnings during high-load Ask operations that alarm users during load testing

Fixes #8037

apoorvdarshan and others added 2 commits February 17, 2026 21:40
The /temp VirtualPathContainer logs "trying to remove non-child" at
Warning level when ConcurrentDictionary.TryRemove returns false. This
is expected, benign behavior during concurrent Ask operations — it
simply means the entry was already removed. Logging it as Warning
creates noise during load testing.

Fixes akkadotnet#8037
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty

@Aaronontheweb Aaronontheweb merged commit 2226305 into akkadotnet:dev Feb 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VirtualPathContainer logs "trying to remove non-child" warnings under high Ask load

2 participants