feat: allow to pass mfa for git sha, git author and app version to lifecycle annotator#163
feat: allow to pass mfa for git sha, git author and app version to lifecycle annotator#163yordis wants to merge 1 commit intoakoutmos:masterfrom
Conversation
…fecycle annotator
|
@akoutmos do you mind giving me your perspective here? I am trying to allow to pass some I am not sure what the configuration should look like. For example: config :app_name, MyApp.PromEx,
lifecycle_annotator: []Or config :app_name, MyApp.PromEx.LifecycleAnnotator,
[
# ...
]I am liking the latter since it is easier to implement and maintain. |
|
I would actually prefer the first version over the second as the second one leaks the internal implementation of the library to the user. What GenServers are started under the PromEx supervision tree is an implementation detail and could change in the future. Let's move forward with the first version, and soft deprecate the |
Change description
What problem does this solve?
PromEx.LifecycleAnnotatorforces us to useGIT_SHA,GIT_AUTHORandvsnapplication spec to configure the annotation.We would like to have the ability, as we do with
PromEx.Plugins.Application, to pass an MFA configuration for all those values so we can customize it to our needs.Issue number: (if applicable)
Example usage
Additional details and screenshots
Checklist