Skip to content

Conversation

@rfyiamcool
Copy link
Contributor

change

add batch put command. 😁

@akrylysov
Copy link
Owner

Thanks for the contribution. Is it just some syntactic sugar for the existing Put? This implementation doesn't improve the performance, you save a bit on acquiring the mutex only once per batch, but on the other hand it may cause issues for reads if the mutex is held for too long when inserting a large number of keys.

@rfyiamcool
Copy link
Contributor Author

Thanks for the contribution. Is it just some syntactic sugar for the existing Put? This implementation doesn't improve the performance, you save a bit on acquiring the mutex only once per batch, but on the other hand it may cause issues for reads if the mutex is held for too long when inserting a large number of keys.

Just to reduce the lock time. 😅 In local kv read/write case, this optimization seems to have no other benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants