Skip to content

support custom API base URL #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support custom API base URL #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fa0b2c
supoprt custom API base URL
hyww Nov 5, 2019
10cc972
add test for custom rest API base URL
hyww Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions mongodbatlas/mongodb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"github.com/dghubble/sling"
)

const apiURL = "https://cloud.mongodb.com/api/atlas/v1.0/"
const atlasURL = "https://cloud.mongodb.com/api/atlas/v1.0/"

// Client is a MongoDB Atlas client for making MongoDB API requests.
type Client struct {
Expand All @@ -25,8 +25,13 @@ type Client struct {
PrivateIPMode *PrivateIPModeService
}

// NewClient returns a new Client.
// NewClient returns a new Client using MongoDB Atlas API Base URL
func NewClient(httpClient *http.Client) *Client {
return NewCustomURLClient(httpClient, atlasURL)
}

// NewCustomURLClient returns a new Client using provided API Base URL
func NewCustomURLClient(httpClient *http.Client, apiURL string) *Client {
base := sling.New().Client(httpClient).Base(apiURL)

return &Client{
Expand Down
19 changes: 19 additions & 0 deletions mongodbatlas/root_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,22 @@ func TestRootService_Get(t *testing.T) {
assert.Nil(t, err)
assert.Equal(t, expected, root)
}

func TestCloudManagerRootService_Get(t *testing.T) {
httpClient, mux, server := testServer()
defer server.Close()

mux.HandleFunc("/api/public/v1.0/", func(w http.ResponseWriter, r *http.Request) {
assertMethod(t, "GET", r)
fmt.Fprintf(w, `{"appName":"MongoDB Cloud Manager","build":"2cf9112fd6b8f59c03a9d1d4cbf32004424e728e","links":[{"href":"https://cloud.mongodb.com/api/public/v1.0","rel":"self"},{"href":"https://cloud.mongodb.com/api/public/v1.0/orgs/000000000000000000000000/apiKeys/000000000000000000000000","rel":"http://mms.mongodb.com/apiKeys"},{"href":"https://cloud.mongodb.com/api/public/v1.0/groups","rel":"http://mms.mongodb.com/groups"},{"href":"https://cloud.mongodb.com/api/public/v1.0/admin/backup","rel":"http://mms.mongodb.com/backupAdmin"}],"throttling":false}`)
})

client := NewCustomURLClient(httpClient, "https://cloud.mongodb.com/api/public/v1.0/")
root, _, err := client.Root.Get()
expected := &Root{
AppName: "MongoDB Cloud Manager",
Build: "2cf9112fd6b8f59c03a9d1d4cbf32004424e728e",
}
assert.Nil(t, err)
assert.Equal(t, expected, root)
}