Skip to content

fix: add database url fintech patterns (#90)#4784

Open
abisheik687 wants to merge 1 commit intoakto-api-security:masterfrom
abisheik687:fix/issue-90-database-url-patterns
Open

fix: add database url fintech patterns (#90)#4784
abisheik687 wants to merge 1 commit intoakto-api-security:masterfrom
abisheik687:fix/issue-90-database-url-patterns

Conversation

@abisheik687
Copy link
Copy Markdown

Summary

This PR adds the missing database URL data types requested in issue #90 to Akto's fintech PII definitions and extends the existing fintech regression test to cover them. It also makes the test read the local pii-types/fintech.json file so the assertions validate the checked-in patterns directly.

Related issue

Closes #90

Changes made

  • Added new fintech regex patterns in pii-types/fintech.json for SQL database URLs, Mongo database URLs, Amazon S3 URLs, RDS database URLs, Prometheus database URLs, and Redis database URLs
  • Updated TestFintechTypes to seed from the local pii-types/fintech.json file instead of a remote GitHub URL
  • Added positive and negative regression assertions for each new URL pattern in TestFintechTypes

How to test

  1. Check out this branch
  2. Ensure protobuf generated sources are available for the current dashboard build
  3. Run the dashboard fintech test: mvn -pl apps/dashboard -am -Dtest=TestFintechTypes -Dsurefire.failIfNoSpecifiedTests=false test
  4. Confirm the new assertions pass for the added URL types
  5. Optionally inspect the loaded custom data types to verify the six new fintech URL patterns are present

Screenshots / logs (if applicable)

Not applicable

Checklist:

  • Code follows the project's style guidelines
  • Tests have been added/updated and all pass
  • PR is scoped to a single issue
  • PR description clearly explains the change

@abisheik687
Copy link
Copy Markdown
Author

Hi! This PR is ready for review.

I added the missing fintech database URL patterns requested in #90 and updated the existing regression test to cover them from the local pii-types/fintech.json file.

I also noticed the GitHub workflow is awaiting maintainer approval. Once that is approved, I’m happy to address any feedback quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚡️ Add sensitive data types for Database URL patterns

1 participant