fix: add database url fintech patterns (#90)#4784
Open
abisheik687 wants to merge 1 commit intoakto-api-security:masterfrom
Open
fix: add database url fintech patterns (#90)#4784abisheik687 wants to merge 1 commit intoakto-api-security:masterfrom
abisheik687 wants to merge 1 commit intoakto-api-security:masterfrom
Conversation
Author
|
Hi! This PR is ready for review. I added the missing fintech database URL patterns requested in #90 and updated the existing regression test to cover them from the local I also noticed the GitHub workflow is awaiting maintainer approval. Once that is approved, I’m happy to address any feedback quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing database URL data types requested in issue #90 to Akto's fintech PII definitions and extends the existing fintech regression test to cover them. It also makes the test read the local
pii-types/fintech.jsonfile so the assertions validate the checked-in patterns directly.Related issue
Closes #90
Changes made
pii-types/fintech.jsonfor SQL database URLs, Mongo database URLs, Amazon S3 URLs, RDS database URLs, Prometheus database URLs, and Redis database URLsTestFintechTypesto seed from the localpii-types/fintech.jsonfile instead of a remote GitHub URLTestFintechTypesHow to test
mvn -pl apps/dashboard -am -Dtest=TestFintechTypes -Dsurefire.failIfNoSpecifiedTests=false testScreenshots / logs (if applicable)
Not applicable
Checklist: