Skip to content

fix autocomplete showcases - pick the wrong item onSelect #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreiPirovich wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix autocomplete showcases - pick the wrong item onSelect #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/scenes/components/autocomplete/autocomplete-showcase.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { useCallback } from 'react';
import { StyleSheet } from 'react-native';
import {
Autocomplete,
Expand All @@ -13,20 +13,20 @@ export const AutocompleteShowcase = (
const [value, setValue] = React.useState<string>(props.value);
const [data, setData] = React.useState(props.data);

const onSelect = (index: number): void => {
setValue(props.data[index].title);
};
const onSelect = useCallback((index: number): void => {
setValue(data[index].title);
}, [data]);

const RenderComponent = props.renderItem;

const onChangeText = (query: string): void => {
const onChangeText = useCallback((query: string): void => {
const visibleData = props.data.filter((item) => {
return item.title.toLowerCase().includes(query.toLowerCase());
});

setValue(query);
setData(visibleData);
};
}, [props.data]);

const renderOption = (item, index): React.ReactElement => (
<AutocompleteItem key={index} title={item.title} />
Expand Down