Conversation
* change components selectors to start with 'npg' prefix instead of 'nb' * use @HostBinding decorator instead of host property * fix negated async pipes * remove duplicated routes in 'playground-routing.module' * format unformatted code with prettier
* use @HostBinding decorator instead of host property * use 'eslint-disable-next-line' comment to disable some rules without breaking changes * format unformatted code with prettier
* use strict equality instead of loose equality in components template * format unformatted code with prettier
* use strict equality instead of loose equality in components template * format unformatted code with prettier * rmove unnecessary @input alias * fix un-safe takeUntil 'rxjs' * add missing components name suffixes * fix shadow variables '@typescript-eslint/no-shadow'
* update typescript and tslib * update eslint and eslint plugins * update zone.js and angular packages * update 'peerDependencies' versions in @nebular/* packages * migrate playground, packages-smoke and @nebular packages to angular 16
fix the warning that was showing due to 'strict unary operators'
* fix fakeAsync tests * fix binding properties name for 'nb-select-with-autocomplete'
* fix broken schematics test specs * use getAppModulePath util from '@schematics/angular' instead of defining our own * use runSchematic instead of runSchematicAsync method becuase it is deprecated * use runExternalSchematic instead of runExternalSchematicAsync method becuase it is deprecated
Because it has been changed to a function that implements CanActivateFn
|
@elupanov @azaiko-akveo |
|
Will there be any comments? |
|
|
Hi. I'm not an active maintainer here, just occasionally fixing some bugs. The only comment I can give is that there are a loooooot of changes: 837 files and 38k of changed lines. Also, not all of the changes are about angular update. It will be hard to review that. Actually, I think that it'll be simpler to perform such an update manually from scratch than to review 38k+ changes. I suggest you try a workaround for installing nebular with angular v16: use I hope that this will help. |
|
I've tried |
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
feat: update to angular 16
fix(theme/styles): add a space after '+' operator
fix(NbSelectWithAutocompleteComponent/spec): fix test spec
build(gulp): remove incorrect 'typeRoots' from tsconfig
fix(schematics): fix project schematics issues
refactor(playground): fix linting issues
remove duplicated routes in 'playground-routing.module'ng serverefactor(framework/theme): fix linting issues
refactor(framework/auth): refactor to pass linter
refactor(docs): refactor to pass linter