Skip to content

Comments

[#725] fix: implement comprehensive case-insensitive support for case import#726

Merged
wayangalihpratama merged 2 commits intostagingfrom
feature/725-bug-manual-segmentation-threshold-adjustment
Feb 20, 2026
Merged

[#725] fix: implement comprehensive case-insensitive support for case import#726
wayangalihpratama merged 2 commits intostagingfrom
feature/725-bug-manual-segmentation-threshold-adjustment

Conversation

@wayangalihpratama
Copy link
Contributor

@wayangalihpratama wayangalihpratama commented Feb 20, 2026

Summary

This PR implements broad case-insensitive support for the case import module and fixes a bug where adjusting segment thresholds incorrectly reset subsequent segment ranges to the global minimum.

Key Changes

  • Sheet Names: Added case-insensitive sheet name resolution for "Data" and "Mapping".
  • Variable Matching: Updated backend utilities (case_import_processing.py, case_import_process_confirmed_segmentation.py) and frontend components (SegmentConfigurationForm.js) to use case-insensitive matching for variable names.
  • Segment Range Fix: Corrected the logic in recalculate_numerical_segments to properly identify the boundary of the previous segment regardless of variable name casing.
  • Validation: Updated the validation flag lookup ("Ready for upload: YES") to be case-insensitive.

Verification

  • Backend Tests: Ran tests/test_segmentation_repro.py, all passed.
  • Frontend Linting: Ran yarn lint, all passed.
  • Manual Verification: Try to create segment using data upload feature, then manually adjust the segment. The segment should provide correct segment range.

Close #725


@wayangalihpratama wayangalihpratama linked an issue Feb 20, 2026 that may be closed by this pull request
@wayangalihpratama wayangalihpratama self-assigned this Feb 20, 2026
@wayangalihpratama wayangalihpratama merged commit ced1ec8 into staging Feb 20, 2026
1 check passed
@wayangalihpratama wayangalihpratama deleted the feature/725-bug-manual-segmentation-threshold-adjustment branch February 20, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Manual segmentation threshold adjustment

1 participant