Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/autofix/lib/rules/no-new-wrappers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/**
* @fileoverview Add fixer to rule no-new-wrappers.
* @author SukkaW <[email protected]>
*/
"use strict";

const ruleComposer = require("eslint-rule-composer");
const utils = require("../utils");

const rule = utils.getFixableRule("no-new-wrappers", true);

module.exports = ruleComposer.mapReports(
rule,
problem => {
if (
problem.node.type !== "NewExpression" || // ignore non new expression
problem.node.arguments.length === 0 // ignore 'const a = new String'
) {
return problem;
}

problem.fix = fixer => fixer.removeRange([problem.node.range[0], problem.node.range[0] + 4]);
return problem;
}
);
60 changes: 60 additions & 0 deletions packages/autofix/tests/lib/rules/no-new-wrappers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/**
* @fileoverview Tests for rule no-new-native-nonconstructor
* @author SukkaW <[email protected]>
*/
"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const rule = require("../../../lib/rules/no-new-wrappers.js");
const RuleTester = require("../../rule-tester.js").RuleTester;

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();

ruleTester.run("no-new-wrappers", rule, {
valid: [
"const text = String(someValue);",
"const num = Number(someValue);",
"const object = new MyString();"
],
invalid: [
{
code: 'const stringObject = new String("Hello world");',
output: 'const stringObject = String("Hello world");',
errors: 1
},
{
code: "const numberObject = new Number(0x721);",
output: "const numberObject = Number(0x721);",
errors: 1
},
{
code: "const booleanObject = new Boolean(false);",
output: "const booleanObject = Boolean(false);",
errors: 1
},

// no auto fix
{
code: "const stringObject = new String",
output: null,
errors: 1
},
{
code: "const numberObject = new Number",
output: null,
errors: 1
},
{
code: "const booleanObject = new Boolean",
output: null,
errors: 1
}
]
});