Feature/improve custom rotate

[quhxl]

Description

This PR improves the usability of the "Rotate by Custom Degrees" tool by addressing two limitations:

• Larger previews: Increased thumbnail height (h-36 to h-64) and reduced grid density to improve visual feedback when adjusting small rotation angles.
• Floating-point support: Replaced parseInt with parseFloat, added step="0.1" to inputs, and implemented rounding to 1 decimal place for more precise control.

Fixes #630

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

🧪 How Has This Been Tested?

Please describe how you tested your changes so that maintainers can verify them. Include enough detail for someone else to reproduce your tests.

Checklist:

• Verified output manually
• Tested with relevant sample documents or data
• Wrote Vite Test Case (if applicable)

Test details:

• Uploaded scanned PDFs with slight skew (~0.5°–2°)
• Applied fractional rotations (e.g. 1.2, -0.8)

Checklist:

• I have signed the Contributor License Agreement (CLA) or my organization has signed the Corporate CLA
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• UI/UX Changes

  • Increased per-page thumbnail height for improved visibility.
  • Adjusted thumbnail grid to show fewer columns on smaller screens and increased spacing between items.

• New Features

  • Rotation controls now accept and apply decimal angles with 0.1° step precision and values normalized to one decimal place for both individual and batch operations.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f8601dd1-0b28-4654-8b7a-09ce0867a0ff

📥 Commits

Reviewing files that changed from the base of the PR and between 0ed5e95 and dd2ee5d.

📒 Files selected for processing (1)

• src/js/logic/rotate-custom-page.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/js/logic/rotate-custom-page.ts

---

📝 Walkthrough

Walkthrough

Increased thumbnail preview size and adjusted grid layout; enabled floating-point rotation inputs with 0.1-degree steps and one-decimal rounding for both per-page and batch rotation controls.

Changes

Rotate by Custom Degrees (preview + decimal angles)

Layer / File(s)	Summary
UI layout / classes src/pages/rotate-custom.html	Grid layout and spacing changed: grid-cols-2 sm:grid-cols-3 md:grid-cols-4 lg:grid-cols-5 gap-4 → grid-cols-1 sm:grid-cols-2 md:grid-cols-2 lg:grid-cols-3 gap-6.
Thumbnail size src/js/logic/rotate-custom-page.ts	Per-page thumbnail container height class changed from h-36 to h-64.
Input attributes src/pages/rotate-custom.html, src/js/logic/rotate-custom-page.ts	Numeric inputs set to step="0.1" and width adjusted (w-12 → w-16) for per-page controls.
Per-page controls: parsing & step handlers src/js/logic/rotate-custom-page.ts	Replaced parseInt with parseFloat in decrement/increment handlers; adjust by ±1, round to one decimal place, and normalize input value.
Per-page Apply src/js/logic/rotate-custom-page.ts	Apply handler parses with parseFloat, rounds to one decimal (fallback 0), normalizes input, stores rounded value into pageState.rotations[pageIndex], and updates thumbnail transform.
Batch controls: parsing & step handlers src/js/logic/rotate-custom-page.ts	Batch decrement/increment parse with parseFloat, adjust by ±1, round to one decimal, and normalize the #batch-custom-angle input.
Batch Apply src/js/logic/rotate-custom-page.ts	Batch Apply parses #batch-custom-angle with parseFloat, rounds to one decimal (fallback 0), normalizes the input, assigns the rounded angle across all pageState.rotations, and refreshes rotation displays.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped in to make things neat,
Thumbnails taller, easier to meet.
Angles whisper, one-decimal tune,
Steps of 0.1 beneath the moon.
A little hop — alignment soon. ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title "Feature/improve custom rotate" is vague and generic, failing to clearly describe the specific improvements (larger previews and floating-point support).	Use a more specific title like "Add floating-point rotation and improve thumbnail previews" to clearly convey the main changes.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description includes all required sections: summary of changes, issue reference (#630), type of change selection, testing methodology with specific test details, and the standard checklist.
Linked Issues check	✅ Passed	Code changes fully address both requirements from issue #630: thumbnail height increased from h-36 to h-64 with reduced grid density for larger previews, and parseInt replaced with parseFloat with step="0.1" for floating-point support.
Out of Scope Changes check	✅ Passed	All changes are directly aligned with issue #630 objectives: thumbnail styling improvements and floating-point rotation input support, with no extraneous modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[quhxl]

I have read the CLA Document and I hereby sign the CLA

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/js/logic/rotate-custom-page.ts`:
- Around line 152-153: The parseFloat usage in the apply handlers (e.g., where
you read input.value and set pageState.rotations[pageIndex]) accepts
NaN/Infinity and un-normalized numbers; fix by validating the parsed value with
Number.isFinite and normalizing to one decimal place before assignment (e.g.,
parse -> Number.isFinite check -> round to one decimal such as Math.round(value
* 10) / 10) and fallback to 0 when invalid; apply the same change to both the
handler that sets pageState.rotations[pageIndex] and the other apply path around
the code referenced near line 393 so all typed angles enforce finite values and
one-decimal precision.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a57585cb-7a59-42ec-9602-678c7aec094f

📥 Commits

Reviewing files that changed from the base of the PR and between ed6e6c0 and 7f9c352.

📒 Files selected for processing (3)

• docs/tools/rotate-custom.md
• src/js/logic/rotate-custom-page.ts
• src/pages/rotate-custom.html

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
32666090	Triggered	Generic Password	dd2ee5d	public/locales/tr/tools.json	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}